MD Settings: update dialogs to focus without ink when using mouse

chrome/browser/resources/settings/settings_page/settings_animated_pages.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-animated-pages' is a container for a page and animated subpages.
  * It provides a set of common behaviors and animations.
  *
  * Example:
@@ skipping 33 matching lines @@
    */
   previousRoute_: null,
 
   /** @override */
   created: function() {
     // Observe the light DOM so we know when it's ready.
     this.lightDomObserver_ =
         Polymer.dom(this).observeNodes(this.lightDomChanged_.bind(this));
   },
 
-  /** @override */
-  attached: function() {
-    this.outline_ = cr.ui.FocusOutlineManager.forDocument(document);
-  },
-
   /**
    * @param {!Event} e
    * @private
    */
   onIronSelect_: function(e) {
     if (!this.focusConfig || !this.previousRoute_)
       return;
 
     // Don't attempt to focus any anchor element, unless last navigation was a
     // 'pop' (backwards) navigation.
@@ skipping 10 matching lines @@
     whitelist += ', settings-subpage[route-path=\"' +
         settings.Route.INTERNET_NETWORKS.path + '\"]';
 // </if>
 
     if (!e.detail.item.matches('neon-animatable, ' + whitelist))
       return;
 
     var selector = this.focusConfig.get(this.previousRoute_.path);
     if (selector) {
       // neon-animatable has "display: none" until the animation finishes, so
-      // calling focus() on any of its children has no effect until
-      // "display: none" is removed. Therefore can't call focus() from within
-      // the currentRouteChanged callback. Using 'iron-select' listener which
-      // fires after the animation has finished allows focus() to work as
-      // expected.
-      var toFocus = this.querySelector(selector);
-      var suppressInk = !this.outline_.visible;
-      var origNoInk;
-
-      if (suppressInk) {
-        origNoInk = toFocus.noink;
-        toFocus.noink = true;
-      }
-
-      toFocus.focus();
-
-      if (suppressInk)
-        toFocus.noink = origNoInk;
+      // calling focus() on any of its children has no effect until "display:
+      // none" is removed. Therefore, don't set focus from within the
+      // currentRouteChanged callback. Using 'iron-select' listener which fires
+      // after the animation has finished allows setting focus to work.
+      cr.ui.focusWithoutInk(assert(this.querySelector(selector)));
     }
   },
 
   /**
    * Called initially once the effective children are ready.
    * @private
    */
   lightDomChanged_: function() {
     if (this.lightDomReady_)
       return;
@@ skipping 97 matching lines @@
     // instance, such that the stamped instance will also be ignored by the
     // searching algorithm.
     if (template.hasAttribute('no-search'))
       subpage.setAttribute('no-search', '');
 
     // Render synchronously so neon-animated-pages can select the subpage.
     template.if = true;
     template.render();
   },
 });