Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8744)

Unified Diff: chrome/common/extensions/docs/templates/articles/richNotifications.html

Issue 2842293002: Adding macOS notes on the rich notification article (Closed)
Patch Set: Correcting based on feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/templates/articles/richNotifications.html
diff --git a/chrome/common/extensions/docs/templates/articles/richNotifications.html b/chrome/common/extensions/docs/templates/articles/richNotifications.html
index 51a7a996bb6843ca95d45077cfedb138b25137ff..1c2808f365f4c0c9182baf4632e5f10c089c2276 100644
--- a/chrome/common/extensions/docs/templates/articles/richNotifications.html
+++ b/chrome/common/extensions/docs/templates/articles/richNotifications.html
@@ -1,5 +1,12 @@
<h1 id="richNotifications">Rich Notifications</h1>
+<p class="note">
+<strong>Platform difference:</strong> In Chrome version 59 the appearance of
+notifications will be different for Mac OS X users. Instead of Chrome's own
mkearney1 2017/04/26 23:29:37 Small nit: missing comma. In Chrome version 59,
+notification UI, native Mac OS X notifications will be used.
+<a href="https://developers.google.com/web/updates/2017/04/native-mac-os-notifications">Learn more in this article</a>.
mkearney1 2017/04/26 23:29:37 Another small nit-- active rather than passive voi
+</p>
+
<p>The <a href="https://developer.chrome.com/apps/notifications">rich notifications API</a>
lets you create notifications using templates and
show these notifications to users in the user's system tray:
@@ -70,6 +77,11 @@ Priorities > 0 are shown for increasing duration and
more high priority notifications can be displayed in the system tray.
</p>
+<p class="note">
+<strong>Platform difference:</strong> The <code>priority</code> will not
+affect the order of notifications in Chrome version 59+ on Mac OS X.
+</p>
mkearney1 2017/04/26 23:29:37 Small nit-- a bit more active: The priority does
+
<p>
In addition to displaying information,
all notification types can include up to two action items.
@@ -143,6 +155,11 @@ template type also includes an <code>imageUrl</code>, which is a link to
an image that is previewed within the notification:
</p>
+<p class="note">
+<strong>Platform difference:</strong> Images will not be display to users using
+Chrome version 59+ on Mac OS X.
+</p>
+
<pre>
var opt = {
type: "basic",
@@ -167,6 +184,11 @@ The <code>list</code> template displays <code>items</code>
in a list format:
</p>
+<p class="note">
+<strong>Platform difference:</strong> Only the first list item will be
+displayed to users in Chrome version 59+ on Mac OS X.
+</p>
+
mkearney1 2017/04/26 23:29:37 Small nit, more active... "Only the first list ite
<pre>
var opt = {
type: "list",
@@ -186,6 +208,12 @@ The <code>progress</code> template displays a progress bar where current
progress ranges from 0 to 100:
</p>
+<p class="note">
+<strong>Platform difference:</strong> In Chrome version 59+ on Mac OS X the
+progress bar display as a percentage value in the title of the notification
+instead of displaying a progress bar.
+</p>
+
mkearney1 2017/04/26 23:29:37 Small nit (typo and more active): In Chrome vers
<pre>
var opt = {
type: "progress",
@@ -196,7 +224,6 @@ var opt = {
}
</pre>
-
<h2 id="events">Listening for and responding to events</h2>
<p>
@@ -225,4 +252,3 @@ function replyBtnClick {
<a href="app_lifecycle#create_event_page">event page</a>,
so that notifications can pop-up even when the app or extension isn't running.
</p>
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698