Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2842283002: Add a clarifying comment explaining why UnknownType.accept() doesn't throw. (Closed)

Created:
3 years, 8 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a clarifying comment explaining why UnknownType.accept() doesn't throw. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/2d508dcc9c66d5822ceabec3ca46adde69011166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/front_end/front_end.iml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_schema.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 8 months ago (2017-04-26 20:48:53 UTC) #2
ahe
lgtm
3 years, 7 months ago (2017-04-27 09:04:27 UTC) #3
Paul Berry
3 years, 7 months ago (2017-04-27 15:36:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d508dcc9c66d5822ceabec3ca46adde69011166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698