Remove AstFactory.field()

Remove AstFactory.field()

This method doesn't really belong in AstFactory, because it's not used
by BodyBuilder; it's used by KernelFieldBuilder, which always builds
kernel objects.  We only need to abstract the objects that are created
by BodyBuilder, since only BodyBuilder is going to have to be capable
of building analyzer ASTs.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/046a62a54fbb0cf546260787a7ec1bad8188d300

[Paul Berry, 2017-04-26 20:39:48]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-04-26 20:40:31]

LGTM

[Paul Berry, 2017-04-26 20:48:04]

Description was changed from

==========
Remove AstFactory.field()

This method doesn't really belong in AstFactory, because it's not used
by BodyBuilder; it's used by KernelFieldBuilder, which always builds
kernel objects.  We only need to abstract the objects that are created
by BodyBuilder, since only BodyBuilder is going to have to be capable
of building analyzer ASTs.
==========

to

==========
Remove AstFactory.field()

This method doesn't really belong in AstFactory, because it's not used
by BodyBuilder; it's used by KernelFieldBuilder, which always builds
kernel objects.  We only need to abstract the objects that are created
by BodyBuilder, since only BodyBuilder is going to have to be capable
of building analyzer ASTs.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/046a62a54fbb0cf546260787a7ec1bad8188d300
==========

[Paul Berry, 2017-04-26 20:48:07]

Committed patchset #1 (id:1) manually as
046a62a54fbb0cf546260787a7ec1bad8188d300 (presubmit successful).

[ahe, 2017-04-27 09:27:20]

lgtm

https://codereview.chromium.org/2842273002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart (right):

https://codereview.chromium.org/2842273002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart:36: final
TypeInferenceEngine typeInferenceEngine;
I think you can remove the above two fields and get them from library.