third_party/WebKit/Source/core/loader/BaseFetchContext.cpp - Issue 2842253002: Move ReportLocalLoadFailed to ExecutionContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/BaseFetchContext.cpp

Issue 2842253002: Move ReportLocalLoadFailed to ExecutionContext (Closed)

Patch Set: Revert ResourceLoader changes, handle main resource redirect in DocumentLoader Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/BaseFetchContext.cpp

diff --git a/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp b/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp

index 7134f9cfb4d51349a7bc472347142dbb5a177979..748ae933ccb7700b068a49eff7a563c9c8567918 100644

--- a/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp

+++ b/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp

@@ -186,8 +186,10 @@ ResourceRequestBlockedReason BaseFetchContext::CanRequestInternal(

if (origin_restriction != FetchParameters::kNoOriginRestriction &&

security_origin && !security_origin->CanDisplay(url)) {

- if (reporting_policy == SecurityViolationReportingPolicy::kReport)

- ReportLocalLoadFailed(url);

+ if (reporting_policy == SecurityViolationReportingPolicy::kReport) {

+ AddConsoleMessage("Not allowed to load local resource: " +

+ url.GetString());

+ }

RESOURCE_LOADING_DVLOG(1) << "ResourceFetcher::requestResource URL was not "

"allowed by SecurityOrigin::CanDisplay";

return ResourceRequestBlockedReason::kOther;