Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2842243003: Add completion support for plugins. (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -15 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 5 chunks +49 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 6 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I'm especially interested to hear your thoughts on whether we should remove of fix the ...
3 years, 8 months ago (2017-04-26 21:19:37 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-04-26 23:45:07 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-04-27 17:26:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d98d672c16298b5e54e357c1284466b44a11e112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698