Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/objects-inl.h

Issue 284223007: Add allocation sites to scratchpad only if a significant amount of mementos was found. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 1548 matching lines...) Expand 10 before | Expand all | Expand 10 after
1559 set_pretenure_data( 1559 set_pretenure_data(
1560 Smi::FromInt(MementoFoundCountBits::update(value, count)), 1560 Smi::FromInt(MementoFoundCountBits::update(value, count)),
1561 SKIP_WRITE_BARRIER); 1561 SKIP_WRITE_BARRIER);
1562 } 1562 }
1563 1563
1564 inline bool AllocationSite::IncrementMementoFoundCount() { 1564 inline bool AllocationSite::IncrementMementoFoundCount() {
1565 if (IsZombie()) return false; 1565 if (IsZombie()) return false;
1566 1566
1567 int value = memento_found_count(); 1567 int value = memento_found_count();
1568 set_memento_found_count(value + 1); 1568 set_memento_found_count(value + 1);
1569 return value == 0; 1569 return value == kPretenureMinimumCreated;
1570 } 1570 }
1571 1571
1572 1572
1573 inline void AllocationSite::IncrementMementoCreateCount() { 1573 inline void AllocationSite::IncrementMementoCreateCount() {
1574 ASSERT(FLAG_allocation_site_pretenuring); 1574 ASSERT(FLAG_allocation_site_pretenuring);
1575 int value = memento_create_count(); 1575 int value = memento_create_count();
1576 set_memento_create_count(value + 1); 1576 set_memento_create_count(value + 1);
1577 } 1577 }
1578 1578
1579 1579
(...skipping 5278 matching lines...) Expand 10 before | Expand all | Expand 10 after
6858 #undef READ_SHORT_FIELD 6858 #undef READ_SHORT_FIELD
6859 #undef WRITE_SHORT_FIELD 6859 #undef WRITE_SHORT_FIELD
6860 #undef READ_BYTE_FIELD 6860 #undef READ_BYTE_FIELD
6861 #undef WRITE_BYTE_FIELD 6861 #undef WRITE_BYTE_FIELD
6862 #undef NOBARRIER_READ_BYTE_FIELD 6862 #undef NOBARRIER_READ_BYTE_FIELD
6863 #undef NOBARRIER_WRITE_BYTE_FIELD 6863 #undef NOBARRIER_WRITE_BYTE_FIELD
6864 6864
6865 } } // namespace v8::internal 6865 } } // namespace v8::internal
6866 6866
6867 #endif // V8_OBJECTS_INL_H_ 6867 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698