pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 2842213003: new TokenType and Keyword API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 2842213003: new TokenType and Keyword API (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index 9e504c6902737cc7121e6159747f1d8170d75b7c..e8c6645adc232292f88ea973a755cd49eda912e3 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -508,7 +508,7 @@ class ReplacementRange {

factory ReplacementRange.compute(int requestOffset, CompletionTarget target) {

bool isKeywordOrIdentifier(Token token) =>

- token.type == TokenType.KEYWORD || token.type == TokenType.IDENTIFIER;

+ token.type.isKeyword || token.type == TokenType.IDENTIFIER;

//TODO(danrubel) Ideally this needs to be pushed down into the contributors

// but that implies that each suggestion can have a different