Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2842213003: new TokenType and Keyword API (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry, scheglov, ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

new TokenType and Keyword API This adds two new methods and adapts most of the old references to use these new API. Once all call sites have been updated, the old API can be removed. This is part one of https://codereview.chromium.org/2842643004/ * replace type == TokenType.KEYWORD with type.isKeyword * change Keyword.syntax --> Keyword.lexeme R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3b790e5311ce3877b1f63a9a0d2beecd11cd6d0a

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -93 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 9 chunks +16 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 9 chunks +14 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/keyword_state.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 5 chunks +18 lines, -5 lines 0 comments Download
M pkg/front_end/test/scanner_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danrubel
3 years, 7 months ago (2017-04-26 17:59:33 UTC) #2
Paul Berry
lgtm
3 years, 7 months ago (2017-04-26 18:31:42 UTC) #3
scheglov
LGTM
3 years, 7 months ago (2017-04-26 18:35:02 UTC) #4
danrubel
Committed patchset #1 (id:1) manually as 3b790e5311ce3877b1f63a9a0d2beecd11cd6d0a (presubmit successful).
3 years, 7 months ago (2017-04-26 19:54:08 UTC) #6
ahe
3 years, 7 months ago (2017-04-27 10:30:33 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698