Issue 2842193002: A crude cut at incorporating stream 1 footer read into stream 0 read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2842193002: A crude cut at incorporating stream 1 footer read into stream 0 read.

Created:
3 years, 7 months ago by Maks Orlovich

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

A crude cut at incorporating stream 1 footer read into stream 0 read. Doesn't seem to help much on desktop, but actually seems to make a clear difference on Android. (See the third tab on https://docs.google.com/spreadsheets/d/1ri_AF3va-yZWIfo66-ZrQHiDpjOcziRdXoprzlqPeVU/edit#gid=1291771432) BUG=

Patch Set 1 #

Patch Set 2 : Rebase. Still needs design re-thought #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -14 lines)			Patch
M	net/disk_cache/simple/simple_entry_impl.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	net/disk_cache/simple/simple_synchronous_entry.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/disk_cache/simple/simple_synchronous_entry.cc	View	1	3 chunks	+52 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Maks Orlovich

Description was changed from ========== A crude cut at incorporating stream 1 footer read into ...

3 years, 7 months ago (2017-04-26 17:00:31 UTC) #1

Maks Orlovich

Description was changed from ========== A crude cut at incorporating stream 1 footer read into ...

3 years, 7 months ago (2017-04-28 14:12:25 UTC) #2

Maks Orlovich

3 years, 7 months ago (2017-04-28 14:44:52 UTC) #3

Description was changed from

==========
A crude cut at incorporating stream 1 footer read into stream 0 read.

Doesn't seem to help much on desktop, but actually seems to make a 
clear difference on Android.

BUG=
==========

to

==========
A crude cut at incorporating stream 1 footer read into stream 0 read.

Doesn't seem to help much on desktop, but actually seems to make a 
clear difference on Android.

(See the third tab on
https://docs.google.com/spreadsheets/d/1ri_AF3va-yZWIfo66-ZrQHiDpjOcziRdXoprz...)


BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages