Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3124)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2842063002: Pass -no-canonical-prefixes to clang by default. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 6a495cc2a82b8b2500a5c7c0c5398b7389c8f0a3..f5ee7b3945cb637a6695999f09518683251dece7 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -437,6 +437,14 @@ config("compiler") {
cflags += [ "-fdebug-prefix-map=$absolute_path=." ]
}
+ # Tells the compiler not to pass the default paths to the tools it invokes.
Nico 2017/04/25 23:21:07 No, it tells the compiler to pass the default path
Dirk Pranke 2017/04/25 23:26:45 Thanks. Updated.
+ # We don't want this because we don't really need it and it can mess up
+ # the goma cache entries. It would be nice if it was on by default in
+ # clang, but it isn't.
Nico 2017/04/25 23:29:20 Can you add a # TODO(thakis): Figure out if this
Dirk Pranke 2017/04/26 00:39:30 Sure.
+ if (is_clang && !is_win) {
+ cflags += [ "-fno-canonical-prefixes" ]
Nico 2017/04/25 23:21:07 It's spelled -no-canonical-prefixes without f I th
Dirk Pranke 2017/04/25 23:26:45 Done.
shinyak 2017/04/26 00:52:00 Yeah, -no-canonical-prefixes is correct. (Could yo
+ }
+
# C++11 compiler flags setup.
# ---------------------------
if (is_linux || is_android || (is_nacl && is_clang)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698