Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: runtime/vm/object_test.cc

Issue 2842053003: Make EqualsIgnoringPrivateKey work with mixin applications. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index a9fa357ca9efd6d2d2e3a71afdd2715fb1d5d137..a67649f6102d9084cf17fd03924dd12bc77080eb 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -3191,6 +3191,16 @@ ISOLATE_UNIT_TEST_CASE(EqualsIgnoringPrivate) {
bare_name = OneByteString::New("food");
EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
+ // Private mixin application match.
+ mangled_name = OneByteString::New("_M1@12345&_M2@12345&_M3@12345");
+ bare_name = OneByteString::New("_M1&_M2&_M3");
+ EXPECT(String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
+
+ // Private mixin application mismatch.
+ mangled_name = OneByteString::New("_M1@12345&_M2@12345&_M3@12345");
+ bare_name = OneByteString::New("_M1&_M2&_M4");
+ EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
+
// Private constructor match.
mangled_name = OneByteString::New("foo@12345.");
bare_name = OneByteString::New("foo.");
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698