Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: runtime/vm/object_test.cc

Issue 2842053003: Make EqualsIgnoringPrivateKey work with mixin applications. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/class_finalizer.h" 8 #include "vm/class_finalizer.h"
9 #include "vm/dart_api_impl.h" 9 #include "vm/dart_api_impl.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 3173 matching lines...) Expand 10 before | Expand all | Expand 10 after
3184 // Private mismatch. 3184 // Private mismatch.
3185 mangled_name = OneByteString::New("food@12345"); 3185 mangled_name = OneByteString::New("food@12345");
3186 bare_name = OneByteString::New("foo"); 3186 bare_name = OneByteString::New("foo");
3187 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name)); 3187 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
3188 3188
3189 // Private mismatch 2. 3189 // Private mismatch 2.
3190 mangled_name = OneByteString::New("foo@12345"); 3190 mangled_name = OneByteString::New("foo@12345");
3191 bare_name = OneByteString::New("food"); 3191 bare_name = OneByteString::New("food");
3192 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name)); 3192 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
3193 3193
3194 // Private mixin application match.
3195 mangled_name = OneByteString::New("_M1@12345&_M2@12345&_M3@12345");
3196 bare_name = OneByteString::New("_M1&_M2&_M3");
3197 EXPECT(String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
3198
3199 // Private mixin application mismatch.
3200 mangled_name = OneByteString::New("_M1@12345&_M2@12345&_M3@12345");
3201 bare_name = OneByteString::New("_M1&_M2&_M4");
3202 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
3203
3194 // Private constructor match. 3204 // Private constructor match.
3195 mangled_name = OneByteString::New("foo@12345."); 3205 mangled_name = OneByteString::New("foo@12345.");
3196 bare_name = OneByteString::New("foo."); 3206 bare_name = OneByteString::New("foo.");
3197 EXPECT(String::EqualsIgnoringPrivateKey(mangled_name, bare_name)); 3207 EXPECT(String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
3198 3208
3199 // Private constructor mismatch. 3209 // Private constructor mismatch.
3200 mangled_name = OneByteString::New("foo@12345."); 3210 mangled_name = OneByteString::New("foo@12345.");
3201 bare_name = OneByteString::New("foo"); 3211 bare_name = OneByteString::New("foo");
3202 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name)); 3212 EXPECT(!String::EqualsIgnoringPrivateKey(mangled_name, bare_name));
3203 3213
(...skipping 1506 matching lines...) Expand 10 before | Expand all | Expand 10 after
4710 // utf32->utf16 conversion. 4720 // utf32->utf16 conversion.
4711 int32_t char_codes[] = {0, 0x0a, 0x0d, 0x7f, 0xff, 4721 int32_t char_codes[] = {0, 0x0a, 0x0d, 0x7f, 0xff,
4712 0xffff, 0xd800, 0xdc00, 0xdbff, 0xdfff}; 4722 0xffff, 0xd800, 0xdc00, 0xdbff, 0xdfff};
4713 4723
4714 const String& str = 4724 const String& str =
4715 String::Handle(String::FromUTF32(char_codes, ARRAY_SIZE(char_codes))); 4725 String::Handle(String::FromUTF32(char_codes, ARRAY_SIZE(char_codes)));
4716 EXPECT(str.Equals(char_codes, ARRAY_SIZE(char_codes))); 4726 EXPECT(str.Equals(char_codes, ARRAY_SIZE(char_codes)));
4717 } 4727 }
4718 4728
4719 } // namespace dart 4729 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698