Bring in pdfium code into third_party/pdfium.

Bring in pdfium code into third_party/pdfium.

R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271449

[brettw, 2014-05-19 18:05:09]

lgtm

[Nico, 2014-05-19 20:52:03]

Is it possible to pull in the src to third_party/pdfium/src and check in the gyp
file directly into chromium's repo? The few repos that have their gyp files not
in chromium's repo always cause me grief when doing compiler changes.

[Nico, 2014-05-19 20:54:23]

On Mon, May 19, 2014 at 1:52 PM, <thakis@chromium.org> wrote:

> Is it possible to pull in the src to third_party/pdfium/src and check in
> the gyp
> file directly into chromium's repo? The few repos that have their gyp
> files not
> in chromium's repo always cause me grief when doing compiler changes.


(Since this repo builds without -Werror, it'll probably be less of an issue
here, but if there's no good reason to keep the gyp file upstream having it
in chromium would still make things a bit simpler.)

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jam, 2014-05-19 21:18:22]

On 2014/05/19 20:54:23, Nico wrote:
> On Mon, May 19, 2014 at 1:52 PM, <mailto:thakis@chromium.org> wrote:
> 
> > Is it possible to pull in the src to third_party/pdfium/src and check in
> > the gyp
> > file directly into chromium's repo? The few repos that have their gyp
> > files not
> > in chromium's repo always cause me grief when doing compiler changes.
> 
> 
> (Since this repo builds without -Werror, it'll probably be less of an issue
> here, but if there's no good reason to keep the gyp file upstream having it
> in chromium would still make things a bit simpler.)

yeah we'd like the gyp to be in that project; as it'll be used by more than
chromium. other projects will generate their own build files from gyp.

also, we are aiming for a separate buildbot for pdfium that runs self-contained
tests, so we'll need the build files there.