Issue 284203005: Get rid of enable-accessibility-logging switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284203005: Get rid of enable-accessibility-logging switch. (Closed)

Created:
6 years, 7 months ago by dmazzoni

Modified:
6 years, 7 months ago

Reviewers:
jam, aboxhall

CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of enable-accessibility-logging switch. This also cleans up the main VLOG in renderer_accessibility_complete so that it uses the new function in ui to convert an AXEvent to a string, and removes the NDEBUG since this is quite useful logging in release builds. Instead of the old switch, use --vmodule="*accessibility*=0" to log accessibility messages that are normally suppressed, possibly combined with --enable-logging=stderr to send them right to your terminal and --log-level=2 to optionally suppress most other log messages. BUG=350457 R=aboxhall@chromium.org, jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271046

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -103 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/accessibility/renderer_accessibility.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/renderer/accessibility/renderer_accessibility.cc	View	3 chunks	+1 line, -85 lines	0 comments	Download
M	content/renderer/accessibility/renderer_accessibility_complete.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

jam, aboxhall: easy review pkasting: fyi (yay for fewer command-line switches)

6 years, 7 months ago (2014-05-15 20:40:10 UTC) #1

dmazzoni

6 years, 7 months ago (2014-05-16 17:38:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r271046 (presubmit successful).

Expand Messages | Collapse Messages