Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 284203002: Fix deopt fuzzer after test runner changes. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, danno
Visibility:
Public.

Description

Fix deopt fuzzer after test runner changes. Use the same keyboard interrupt logic as run-tests. Close the perf database explicitly after one run, as it has two runs on the same architecture. Currently the first run closes on garbage collection, which might corrupt the second run. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M tools/run-deopt-fuzzer.py View 3 chunks +14 lines, -24 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 7 months ago (2014-05-15 12:38:59 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-15 12:40:06 UTC) #2
Michael Achenbach
6 years, 7 months ago (2014-05-15 12:40:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698