Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1706)

Unified Diff: pkg/analysis_server/lib/src/plugin/notification_manager.dart

Issue 2842013003: Add support for watch events and error notifications (Closed)
Patch Set: fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/plugin/notification_manager.dart
diff --git a/pkg/analysis_server/lib/src/plugin/notification_manager.dart b/pkg/analysis_server/lib/src/plugin/notification_manager.dart
index 53d0513091eedaac9de602b99826646ca4772743..99271317efa95de8b92654f3784e909cdff4521f 100644
--- a/pkg/analysis_server/lib/src/plugin/notification_manager.dart
+++ b/pkg/analysis_server/lib/src/plugin/notification_manager.dart
@@ -173,6 +173,17 @@ class NotificationManager {
converter.convertOutline(outline))
.toList());
break;
+ case plugin.PLUGIN_NOTIFICATION_ERROR:
+ plugin.PluginErrorParams params =
+ new plugin.PluginErrorParams.fromNotification(notification);
+ // TODO(brianwilkerson) There is no indication for the client as to the
+ // fact that the error came from a plugin, let alone which plugin it
+ // came from. We should consider whether we really want to send them to
+ // the client.
+ channel.sendNotification(new server.ServerErrorParams(
+ params.isFatal, params.message, params.stackTrace)
+ .toNotification());
+ break;
}
}

Powered by Google App Engine
This is Rietveld 408576698