Add support for watch events and error notifications

Add support for watch events and error notifications

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/65f492a0430b8a2ac02f312145c307c9d30850c5

[Brian Wilkerson, 2017-04-26 14:31:55]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-04-26 15:55:18]

LGTM

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/plugin/plugin_manager.dart (right):

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/plugin/plugin_manager.dart:272: watcher.WatchEvent
watchEvent) async {
Do we await it anywhere?
Or do we want to return the futures just in case?

Is there a reason to return separate futures instead of awaiting all of them
inside and return one (implicit) future?

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/analysis_abstract.dart (right):

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/analysis_abstract.dart:30: import
'package:watcher/src/watch_event.dart';
Maybe package:watcher/watcher.dart?

[Brian Wilkerson, 2017-04-26 16:35:55]

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/plugin/plugin_manager.dart (right):

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/plugin/plugin_manager.dart:272: watcher.WatchEvent
watchEvent) async {
> Do we await it anywhere?
> Or do we want to return the futures just in case?

It's useful in test code to allow us to know whether or not the plugin received
the request.

> Is there a reason to return separate futures instead of awaiting all of them
> inside and return one (implicit) future?

Only for consistency with broadcastRequest, which returns the individual
responses. Given that these responses will be empty (baring errors), that's a
fairly thin reason.

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/analysis_abstract.dart (right):

https://codereview.chromium.org/2842013003/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/analysis_abstract.dart:30: import
'package:watcher/src/watch_event.dart';
Done (We really need to fix the quick fixes, etc. to not suggest private
libraries when there is a public option!)

[Brian Wilkerson, 2017-04-26 16:36:30]

Description was changed from

==========
Add support for watch events and error notifications
==========

to

==========
Add support for watch events and error notifications

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/65f492a0430b8a2ac02f312145c307c9d30850c5
==========

[Brian Wilkerson, 2017-04-26 16:36:31]

Committed patchset #2 (id:20001) manually as
65f492a0430b8a2ac02f312145c307c9d30850c5 (presubmit successful).