Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/browser/permissions/permission_service_impl.h

Issue 2842013002: Use a mojo::StrongBindingSet to manage PermissionServiceImpls (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/permissions/permission_service_impl.h
diff --git a/content/browser/permissions/permission_service_impl.h b/content/browser/permissions/permission_service_impl.h
index 7617697a524a0753652fe30f788c7954025455dd..cfce9155afdf1bf9a3b0ee39cca9d92df2aa0e8c 100644
--- a/content/browser/permissions/permission_service_impl.h
+++ b/content/browser/permissions/permission_service_impl.h
@@ -10,7 +10,6 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "content/browser/permissions/permission_service_context.h"
-#include "mojo/public/cpp/bindings/binding.h"
#include "third_party/WebKit/public/platform/modules/permissions/permission.mojom.h"
#include "url/origin.h"
@@ -27,16 +26,9 @@ enum class PermissionType;
// WebContents for example.
class PermissionServiceImpl : public blink::mojom::PermissionService {
public:
- PermissionServiceImpl(
- PermissionServiceContext* context,
- mojo::InterfaceRequest<blink::mojom::PermissionService> request);
+ PermissionServiceImpl(PermissionServiceContext* context);
~PermissionServiceImpl() override;
- // Clear pending operations currently run by the service. This will be called
- // by PermissionServiceContext when it will need the service to clear its
- // state for example, if the frame changes.
- void CancelPendingOperations();
-
private:
using PermissionStatusCallback =
base::Callback<void(blink::mojom::PermissionStatus)>;
@@ -75,8 +67,6 @@ class PermissionServiceImpl : public blink::mojom::PermissionService {
blink::mojom::PermissionStatus last_known_status,
blink::mojom::PermissionObserverPtr observer) override;
- void OnConnectionError();
-
void OnRequestPermissionResponse(int pending_request_id,
blink::mojom::PermissionStatus status);
void OnRequestPermissionsResponse(
@@ -94,7 +84,6 @@ class PermissionServiceImpl : public blink::mojom::PermissionService {
RequestsMap pending_requests_;
// context_ owns |this|.
PermissionServiceContext* context_;
- mojo::Binding<blink::mojom::PermissionService> binding_;
base::WeakPtrFactory<PermissionServiceImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(PermissionServiceImpl);
« no previous file with comments | « content/browser/permissions/permission_service_context.cc ('k') | content/browser/permissions/permission_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698