Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

Issue 2842003003: Make AudioBufferSourceNode.buffer setter conforming (Closed)
Patch Set: Update expected result Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
index 5cc78d303eee243a5e7321ec1949179fbe437460..22cb1142cd5f827a6c072efe2a1740693a4330b5 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
@@ -180,6 +180,10 @@ class AudioBufferSourceHandler final : public AudioScheduledSourceHandler {
// TODO: when the codebase adopts std::atomic<>, use it for
// |min_playback_rate_|.
Mutex min_playback_rate_mutex_;
+
+ // True if the |buffer| attribute has ever been set to a non-null
+ // value. Defaults to false.
+ bool buffer_has_been_set_;
hongchan 2017/07/28 18:45:32 Add ` = false;` and remove the comment about the d
Raymond Toy 2017/07/28 19:16:55 The constructor needs to initialize other things,
};
class AudioBufferSourceNode final : public AudioScheduledSourceNode {

Powered by Google App Engine
This is Rietveld 408576698