Issue 2841983002: Use a fully qualified type name. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(745)

My Issues | Starred Open | Closed | All

Issue 2841983002: Use a fully qualified type name. (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)

Modified:
3 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use a fully qualified type name. BUG= Committed: https://github.com/dart-lang/sdk/commit/917cb4d80a5810e57b3af080f02fbd46c73f1567

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/bin/main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

It looks like Clang is more forgiving the gcc and Windows compilers.

3 years, 7 months ago (2017-04-25 18:21:36 UTC) #2

Kevin Millikin (Google)

Committed patchset #1 (id:1) manually as 917cb4d80a5810e57b3af080f02fbd46c73f1567 (presubmit successful).

3 years, 7 months ago (2017-04-25 18:22:16 UTC) #4

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698