Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4226)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 2841943002: Overlay scrollbars expand only when mouse is near thumb (Closed)
Patch Set: pass point to SingleScrollbarController Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 5d38bf58c59e6a0558d27ff10c0c3f58740612b4..bb6596266a39e33d9b87f8a74a1a8a985cbc3b57 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -3390,21 +3390,6 @@ InputHandler::ScrollStatus LayerTreeHostImpl::FlingScrollBegin() {
return scroll_status;
}
-float LayerTreeHostImpl::DeviceSpaceDistanceToLayer(
- const gfx::PointF& device_viewport_point,
- LayerImpl* layer_impl) {
- if (!layer_impl)
- return std::numeric_limits<float>::max();
-
- gfx::Rect layer_impl_bounds(layer_impl->bounds());
-
- gfx::RectF device_viewport_layer_impl_bounds = MathUtil::MapClippedRect(
- layer_impl->ScreenSpaceTransform(), gfx::RectF(layer_impl_bounds));
-
- return device_viewport_layer_impl_bounds.ManhattanDistanceToPoint(
- device_viewport_point);
-}
-
void LayerTreeHostImpl::MouseDown() {
ScrollbarAnimationController* animation_controller =
ScrollbarAnimationControllerForElementId(
@@ -3472,12 +3457,7 @@ void LayerTreeHostImpl::MouseMoveAt(const gfx::Point& viewport_point) {
if (!new_animation_controller)
return;
- for (auto* scrollbar : active_tree_->ScrollbarsFor(scroll_element_id)) {
- new_animation_controller->DidMouseMoveNear(
- scrollbar->orientation(),
- DeviceSpaceDistanceToLayer(device_viewport_point, scrollbar) /
- active_tree_->device_scale_factor());
- }
+ new_animation_controller->DidMouseMove(device_viewport_point);
}
void LayerTreeHostImpl::MouseLeave() {

Powered by Google App Engine
This is Rietveld 408576698