Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4402)

Unified Diff: cc/input/scrollbar_animation_controller.h

Issue 2841943002: Overlay scrollbars expand only when mouse is near thumb (Closed)
Patch Set: pass point to SingleScrollbarController Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/scrollbar_animation_controller.h
diff --git a/cc/input/scrollbar_animation_controller.h b/cc/input/scrollbar_animation_controller.h
index c34273e57ee835c1cd082014b65aae4544008ae6..2c971c7e857d19dec44449fad2ce7c944914d300 100644
--- a/cc/input/scrollbar_animation_controller.h
+++ b/cc/input/scrollbar_animation_controller.h
@@ -82,13 +82,14 @@ class CC_EXPORT ScrollbarAnimationController {
void DidMouseDown();
void DidMouseUp();
void DidMouseLeave();
- void DidMouseMoveNear(ScrollbarOrientation, float);
+ void DidMouseMove(const gfx::PointF& device_viewport_point);
// Called when Blink wants to show the scrollbars (via
// ScrollableArea::showOverlayScrollbars).
void DidRequestShowFromMainThread();
- bool MouseIsOverScrollbar(ScrollbarOrientation orientation) const;
+ bool MouseIsOverScrollbarThumb(ScrollbarOrientation orientation) const;
bokan 2017/04/28 18:08:11 Add a comment that these methods are public for te
+ bool MouseIsNearScrollbarThumb(ScrollbarOrientation orientation) const;
bool MouseIsNearScrollbar(ScrollbarOrientation orientation) const;
bool MouseIsNearAnyScrollbar() const;
@@ -129,9 +130,6 @@ class CC_EXPORT ScrollbarAnimationController {
bool Captured() const;
- bool CalcNeedTriggerScrollbarShow(ScrollbarOrientation orientation,
- float distance) const;
-
void ApplyOpacityToScrollbars(float opacity);
ScrollbarAnimationControllerClient* client_;
@@ -143,7 +141,7 @@ class CC_EXPORT ScrollbarAnimationController {
base::TimeDelta fade_duration_;
- bool need_trigger_scrollbar_show_;
+ bool need_trigger_scrollbar_fade_in_;
bool is_animating_;
AnimationChange animation_change_;
@@ -158,6 +156,7 @@ class CC_EXPORT ScrollbarAnimationController {
const bool show_scrollbars_on_scroll_gesture_;
const bool need_thinning_animation_;
+
std::unique_ptr<SingleScrollbarAnimationControllerThinning>
vertical_controller_;
std::unique_ptr<SingleScrollbarAnimationControllerThinning>
« no previous file with comments | « no previous file | cc/input/scrollbar_animation_controller.cc » ('j') | cc/input/scrollbar_animation_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698