chrome/browser/subresource_filter/subresource_filter_browsertest.cc - Issue 2841933003: [subresource_filter] Remove some state from the driver factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Issue 2841933003: [subresource_filter] Remove some state from the driver factory (Closed)

Patch Set: no more dep branch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('k') | components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

diff --git a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

index 61e93674f650ec1f7ab7e28416e58eaf3002a530..f7f872f8645ba31fead6a450d31fb5364d8b60df 100644

--- a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

+++ b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

@@ -46,6 +46,7 @@

#include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"

#include "components/subresource_filter/core/browser/subresource_filter_features.h"

#include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"

+#include "components/subresource_filter/core/common/activation_decision.h"

#include "components/subresource_filter/core/common/activation_level.h"

#include "components/subresource_filter/core/common/activation_state.h"

#include "components/subresource_filter/core/common/scoped_timers.h"

@@ -175,8 +176,6 @@ using subresource_filter::testing::ScopedSubresourceFilterFeatureToggle;

using subresource_filter::testing::TestRulesetPublisher;

using subresource_filter::testing::TestRulesetCreator;

using subresource_filter::testing::TestRulesetPair;

-using ActivationDecision =

- ContentSubresourceFilterDriverFactory::ActivationDecision;

// SubresourceFilterDisabledBrowserTest ---------------------------------------