Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 284193005: Rename GCMClientMock to FakeGCMClient (Closed)

Created:
6 years, 7 months ago by jianli
Modified:
6 years, 7 months ago
Reviewers:
fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Rename GCMClientMock to FakeGCMClient Also remove gcm_service_unittest that is forgot to delete last time BUG=356716 TEST=existing tests TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -1823 lines) Patch
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/services/gcm/fake_gcm_client.h View 1 chunk +94 lines, -94 lines 0 comments Download
A + chrome/browser/services/gcm/fake_gcm_client.cc View 7 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_client_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_client_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/services/gcm/gcm_client_mock.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/services/gcm/gcm_client_mock.cc View 1 chunk +0 lines, -219 lines 0 comments Download
M chrome/browser/services/gcm/gcm_driver_unittest.cc View 20 chunks +41 lines, -41 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
D chrome/browser/services/gcm/gcm_service_unittest.cc View 1 chunk +0 lines, -1322 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jianli
6 years, 7 months ago (2014-05-15 18:40:49 UTC) #1
fgorski
lgtm
6 years, 7 months ago (2014-05-15 19:11:11 UTC) #2
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 7 months ago (2014-05-15 19:12:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/284193005/1
6 years, 7 months ago (2014-05-15 19:13:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 20:47:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 20:51:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/152483)
6 years, 7 months ago (2014-05-15 20:51:13 UTC) #7
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 7 months ago (2014-05-15 21:01:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/284193005/1
6 years, 7 months ago (2014-05-15 21:01:49 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 21:29:05 UTC) #10
Message was sent while issue was closed. 
Change committed as 270822

Powered by Google App Engine
This is Rietveld 408576698