Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: syzygy/core/disassembler_util_unittest.cc

Issue 2841863003: Improve the decoding of the VEX encoded instructions. (Closed)
Patch Set: Use a constant. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« syzygy/core/disassembler_util.cc ('K') | « syzygy/core/disassembler_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/core/disassembler_util_unittest.cc
diff --git a/syzygy/core/disassembler_util_unittest.cc b/syzygy/core/disassembler_util_unittest.cc
index e422c9b8ce914da76358d1af7e4f4a4299dc3342..76b11dec82d925e8cf848128cf623ac170d57d56 100644
--- a/syzygy/core/disassembler_util_unittest.cc
+++ b/syzygy/core/disassembler_util_unittest.cc
@@ -126,12 +126,13 @@ const std::vector<std::vector<uint8_t>> kVexInstructions = {
{0xC4, 0xE2, 0x7D, 0x5A, 0x45, 0xD0}, // vbroadcasti128
{0xC4, 0xE3, 0x7D, 0x38, 0x2C, 0x0F, 0x01}, // vinserti128
{0xC4, 0xE2, 0x79, 0x78, 0xC0}, // vpbroadcastb
- {0xC4, 0xE2, 0x7D, 0x58, 0x40, 0x04}, // vpbroadcastd
+ {0xC4, 0xE2, 0x79, 0x78, 0x40, 0x04}, // vpbroadcastb (2 operands)
+ {0xC4, 0xE2, 0x7D, 0x58, 0xC0}, // vpbroadcastd
+ {0xC4, 0xE2, 0x7D, 0x58, 0x40, 0x04}, // vpbroadcastd (2 operands)
{0xC4, 0xE2, 0x7D, 0x18, 0xC0}, // vbroadcastss
{0xC4, 0xE3, 0x7D, 0x39, 0xC8, 0x01}, // vextracti128
{0xC4, 0xE2, 0x7D, 0x90, 0x1C, 0x88}, // vpgatherdd
{0xC4, 0xE2, 0x7D, 0x8C, 0x00}, // vpmaskmovd
- {0xC4, 0xE2, 0x7D, 0x8E, 0x90}, // vpmaskmovd
// F16C instructions.
{0xC4, 0xE3, 0x79, 0x1D, 0xC8, 0x00}, // vcvtps2ph
« syzygy/core/disassembler_util.cc ('K') | « syzygy/core/disassembler_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698