Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(773)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: pkg/front_end/lib/src/fasta/kernel/utils.dart
Issue
2841863002
:
Change accessors and AstFactory to use tokens rather than file offsets. (Closed)
Patch Set: Address code review comments, rebase
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pkg/front_end/lib/src/fasta/builder/ast_factory.dart
pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart
pkg/front_end/lib/src/fasta/kernel/utils.dart
View unified diff
|
Download patch
« no previous file with comments
|
« pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2
// for details. All rights reserved. Use of this source code is governed by a
3
// BSD-style license that can be found in the LICENSE file.
4
5
import 'package:front_end/src/fasta/scanner/token.dart';
6
import 'package:kernel/ast.dart';
7
8
/// A null-aware alternative to `token.offset`. If [token] is `null`, returns
9
/// `TreeNode.noOffset`.
10
int offsetForToken(Token token) =>
11
token == null ? TreeNode.noOffset : token.offset;
OLD
NEW
« no previous file with comments
|
« pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart
('k') |
no next file »
|
no next file with comments »
Issue 2841863002: Change accessors and AstFactory to use tokens rather than file offsets. (Closed)
Created 3 years, 8 months ago by Paul Berry
Modified 3 years, 8 months ago
Reviewers: ahe
Base URL:
Comments: 16
This is Rietveld
408576698
Chromium Code Reviews
Issue 2841863002:
Change accessors and AstFactory to use tokens rather than file offsets. (Closed)
