Change accessors and AstFactory to use tokens rather than file offsets.

pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// A library to help transform compounds and null-aware accessors into
 /// let expressions.
 
+import 'package:front_end/src/fasta/kernel/utils.dart' show offsetForToken;
+
+import 'package:front_end/src/fasta/scanner/token.dart' show Token;
+
 import 'package:front_end/src/fasta/kernel/fasta_accessors.dart'
     show BuilderHelper;
 
 import 'package:kernel/ast.dart';
 
 final Name indexGetName = new Name("[]");
 
 final Name indexSetName = new Name("[]=");
 
 /// An [Accessor] represents a subexpression for which we can't yet build a
 /// kernel [Expression] because we don't yet know the context in which it is
 /// used.
 ///
 /// Once the context is known, an [Accessor] can be converted into an
 /// [Expression] by calling a "build" method.
 ///
 /// For example, when building a kernel representation for `a[x] = b`, after
 /// parsing `a[x]` but before parsing `= b`, we don't yet know whether to
 /// generate an invocation of `operator[]` or `operator[]=`, so we generate an
 /// [Accessor] object.  Later, after `= b` is parsed, [buildAssignment] will be
 /// called.
 abstract class Accessor {
-  final int offset;
+  final Token token;
 
   // [builtBinary] and [builtGetter] capture the inner nodes. Used by
   // dart2js+rasta for determining how subexpressions map to legacy dart2js Ast
   // nodes. This will be removed once dart2js type analysis (aka inference) is
   // reimplemented on kernel.
   Expression builtBinary;
   Expression builtGetter;
 
-  Accessor(this.offset);
+  Accessor(this.token);
 
   /// Builds an [Expression] representing a read from the accessor.
   Expression buildSimpleRead() {
     return _finish(_makeSimpleRead());
   }
 
   /// Builds an [Expression] representing an assignment with the accessor on
   /// the LHS and [value] on the RHS.
   ///
   /// The returned expression evaluates to the assigned value, unless
@@ skipping 90 matching lines @@
   /// At runtime, [value] will be evaluated before throwing an exception.
   makeInvalidWrite(Expression value) => wrapInvalid(value);
 }
 
 abstract class VariableAccessor extends Accessor {
   VariableDeclaration variable;
   DartType promotedType;
 
   BuilderHelper get helper;
 
-  VariableAccessor(this.variable, this.promotedType, int offset)
-      : super(offset);
+  VariableAccessor(this.variable, this.promotedType, Token token)
+      : super(token);
 
   Expression _makeRead() {
     var fact = helper.typePromoter
         .getFactForAccess(variable, helper.functionNestingLevel);
     var scope = helper.typePromoter.currentScope;
-    return helper.astFactory.variableGet(variable, fact, scope, offset);
+    return helper.astFactory.variableGet(variable, fact, scope, token);
   }
 
   Expression _makeWrite(Expression value, bool voidContext) {
     helper.typePromoter.mutateVariable(variable, helper.functionNestingLevel);
     return variable.isFinal || variable.isConst
         ? makeInvalidWrite(value)
         : new VariableSet(variable, value)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 }
 
 class PropertyAccessor extends Accessor {
   VariableDeclaration _receiverVariable;
   Expression receiver;
   Name name;
   Member getter, setter;
 
   static Accessor make(
       Expression receiver, Name name, Member getter, Member setter,
-      {int offset: TreeNode.noOffset}) {
+      {Token token}) {
     if (receiver is ThisExpression) {
-      return new ThisPropertyAccessor(name, getter, setter, offset);
+      return new ThisPropertyAccessor(name, getter, setter, token);
     } else {
       return new PropertyAccessor.internal(
-          receiver, name, getter, setter, offset);
+          receiver, name, getter, setter, token);
     }
   }
 
   PropertyAccessor.internal(
-      this.receiver, this.name, this.getter, this.setter, int offset)
-      : super(offset);
+      this.receiver, this.name, this.getter, this.setter, Token token)
+      : super(token);
 
-  Expression _makeSimpleRead() =>
-      new PropertyGet(receiver, name, getter)..fileOffset = offset;
+  Expression _makeSimpleRead() => new PropertyGet(receiver, name, getter)
+    ..fileOffset = offsetForToken(token);
 
   Expression _makeSimpleWrite(Expression value, bool voidContext) {
-    return new PropertySet(receiver, name, value, setter)..fileOffset = offset;
+    return new PropertySet(receiver, name, value, setter)
+      ..fileOffset = offsetForToken(token);
   }
 
   receiverAccess() {
     _receiverVariable ??= new VariableDeclaration.forValue(receiver);
-    return new VariableGet(_receiverVariable)..fileOffset = offset;
+    return new VariableGet(_receiverVariable)
+      ..fileOffset = offsetForToken(token);
   }
 
-  Expression _makeRead() => builtGetter =
-      new PropertyGet(receiverAccess(), name, getter)..fileOffset = offset;
+  Expression _makeRead() =>
+      builtGetter = new PropertyGet(receiverAccess(), name, getter)
+        ..fileOffset = offsetForToken(token);
 
   Expression _makeWrite(Expression value, bool voidContext) {
     return new PropertySet(receiverAccess(), name, value, setter)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 
   Expression _finish(Expression body) => makeLet(_receiverVariable, body);
 }
 
 /// Special case of [PropertyAccessor] to avoid creating an indirect access to
 /// 'this'.
 class ThisPropertyAccessor extends Accessor {
   Name name;
   Member getter, setter;
 
-  ThisPropertyAccessor(this.name, this.getter, this.setter, int offset)
-      : super(offset);
+  ThisPropertyAccessor(this.name, this.getter, this.setter, Token token)
+      : super(token);
 
-  Expression _makeRead() => builtGetter =
-      new PropertyGet(new ThisExpression(), name, getter)..fileOffset = offset;
+  Expression _makeRead() =>
+      builtGetter = new PropertyGet(new ThisExpression(), name, getter)
+        ..fileOffset = offsetForToken(token);
 
   Expression _makeWrite(Expression value, bool voidContext) {
     return new PropertySet(new ThisExpression(), name, value, setter)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 }
 
 class NullAwarePropertyAccessor extends Accessor {
   VariableDeclaration receiver;
   Name name;
   Member getter, setter;
   DartType type;
 
   NullAwarePropertyAccessor(Expression receiver, this.name, this.getter,
-      this.setter, this.type, int offset)
+      this.setter, this.type, Token token)
       : this.receiver = makeOrReuseVariable(receiver),
-        super(offset);
+        super(token);
 
   receiverAccess() => new VariableGet(receiver);
 
   Expression _makeRead() =>
       builtGetter = new PropertyGet(receiverAccess(), name, getter);
 
   Expression _makeWrite(Expression value, bool voidContext) {
     return new PropertySet(receiverAccess(), name, value, setter);
   }
 
   Expression _finish(Expression body) => makeLet(
       receiver,
       new ConditionalExpression(
           buildIsNull(receiverAccess()), new NullLiteral(), body, type));
 }
 
 class SuperPropertyAccessor extends Accessor {
   Name name;
   Member getter, setter;
 
-  SuperPropertyAccessor(this.name, this.getter, this.setter, int offset)
-      : super(offset);
+  SuperPropertyAccessor(this.name, this.getter, this.setter, Token token)
+      : super(token);
 
   Expression _makeRead() {
     if (getter == null) return makeInvalidRead();
     // TODO(ahe): Use [DirectPropertyGet] when possible.
     return builtGetter = new SuperPropertyGet(name, getter)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 
   Expression _makeWrite(Expression value, bool voidContext) {
     if (setter == null) return makeInvalidWrite(value);
     // TODO(ahe): Use [DirectPropertySet] when possible.
-    return new SuperPropertySet(name, value, setter)..fileOffset = offset;
+    return new SuperPropertySet(name, value, setter)
+      ..fileOffset = offsetForToken(token);
   }
 }
 
 class IndexAccessor extends Accessor {
   Expression receiver;
   Expression index;
   VariableDeclaration receiverVariable;
   VariableDeclaration indexVariable;
   Procedure getter, setter;
 
   static Accessor make(
       Expression receiver, Expression index, Procedure getter, Procedure setter,
-      {int offset: TreeNode.noOffset}) {
+      {Token token}) {
     if (receiver is ThisExpression) {
-      return new ThisIndexAccessor(index, getter, setter, offset);
+      return new ThisIndexAccessor(index, getter, setter, token);
     } else {
-      return new IndexAccessor.internal(
-          receiver, index, getter, setter, offset);
+      return new IndexAccessor.internal(receiver, index, getter, setter, token);
     }
   }
 
   IndexAccessor.internal(
-      this.receiver, this.index, this.getter, this.setter, int offset)
-      : super(offset);
+      this.receiver, this.index, this.getter, this.setter, Token token)
+      : super(token);
 
   Expression _makeSimpleRead() => new MethodInvocation(
       receiver, indexGetName, new Arguments(<Expression>[index]), getter)
-    ..fileOffset = offset;
+    ..fileOffset = offsetForToken(token);
 
   Expression _makeSimpleWrite(Expression value, bool voidContext) {
     if (!voidContext) return _makeWriteAndReturn(value);
     return new MethodInvocation(receiver, indexSetName,
         new Arguments(<Expression>[index, value]), setter)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 
   receiverAccess() {
     // We cannot reuse the receiver if it is a variable since it might be
     // reassigned in the index expression.
     receiverVariable ??= new VariableDeclaration.forValue(receiver);
-    return new VariableGet(receiverVariable)..fileOffset = offset;
+    return new VariableGet(receiverVariable)
+      ..fileOffset = offsetForToken(token);
   }
 
   indexAccess() {
     indexVariable ??= new VariableDeclaration.forValue(index);
-    return new VariableGet(indexVariable)..fileOffset = offset;
+    return new VariableGet(indexVariable)..fileOffset = offsetForToken(token);
   }
 
   Expression _makeRead() {
     return builtGetter = new MethodInvocation(receiverAccess(), indexGetName,
         new Arguments(<Expression>[indexAccess()]), getter)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 
   Expression _makeWrite(Expression value, bool voidContext) {
     if (!voidContext) return _makeWriteAndReturn(value);
     return new MethodInvocation(receiverAccess(), indexSetName,
         new Arguments(<Expression>[indexAccess(), value]), setter)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 
   // TODO(dmitryas): remove this method after the "[]=" operator of the Context
   // class is made to return a value.
   _makeWriteAndReturn(Expression value) {
     // The call to []= does not return the value like direct-style assignments
     // do.  We need to bind the value in a let.
     var valueVariable = new VariableDeclaration.forValue(value);
     var dummy = new VariableDeclaration.forValue(new MethodInvocation(
         receiverAccess(),
         indexSetName,
         new Arguments(
             <Expression>[indexAccess(), new VariableGet(valueVariable)]),
         setter)
-      ..fileOffset = offset);
+      ..fileOffset = offsetForToken(token));
     return makeLet(
         valueVariable, makeLet(dummy, new VariableGet(valueVariable)));
   }
 
   Expression _finish(Expression body) {
     return makeLet(receiverVariable, makeLet(indexVariable, body));
   }
 }
 
 /// Special case of [IndexAccessor] to avoid creating an indirect access to
 /// 'this'.
 class ThisIndexAccessor extends Accessor {
   Expression index;
   VariableDeclaration indexVariable;
   Procedure getter, setter;
 
-  ThisIndexAccessor(this.index, this.getter, this.setter, int offset)
-      : super(offset);
+  ThisIndexAccessor(this.index, this.getter, this.setter, Token token)
+      : super(token);
 
   Expression _makeSimpleRead() {
     return new MethodInvocation(new ThisExpression(), indexGetName,
         new Arguments(<Expression>[index]), getter);
   }
 
   Expression _makeSimpleWrite(Expression value, bool voidContext) {
     if (!voidContext) return _makeWriteAndReturn(value);
     return new MethodInvocation(new ThisExpression(), indexSetName,
         new Arguments(<Expression>[index, value]), setter);
@@ skipping 29 matching lines @@
   }
 
   Expression _finish(Expression body) => makeLet(indexVariable, body);
 }
 
 class SuperIndexAccessor extends Accessor {
   Expression index;
   VariableDeclaration indexVariable;
   Member getter, setter;
 
-  SuperIndexAccessor(this.index, this.getter, this.setter, int offset)
-      : super(offset);
+  SuperIndexAccessor(this.index, this.getter, this.setter, Token token)
+      : super(token);
 
   indexAccess() {
     indexVariable ??= new VariableDeclaration.forValue(index);
     return new VariableGet(indexVariable);
   }
 
   Expression _makeSimpleRead() => new SuperMethodInvocation(
       indexGetName, new Arguments(<Expression>[index]), getter);
 
   Expression _makeSimpleWrite(Expression value, bool voidContext) {
@@ skipping 27 matching lines @@
   Expression _finish(Expression body) {
     return makeLet(indexVariable, body);
   }
 }
 
 class StaticAccessor extends Accessor {
   final BuilderHelper helper;
   Member readTarget;
   Member writeTarget;
 
-  StaticAccessor(this.helper, this.readTarget, this.writeTarget, int offset)
-      : super(offset);
+  StaticAccessor(this.helper, this.readTarget, this.writeTarget, Token token)
+      : super(token);
 
   Expression _makeRead() => builtGetter = readTarget == null
       ? makeInvalidRead()
-      : helper.makeStaticGet(readTarget, offset);
+      : helper.makeStaticGet(readTarget, token);
 
   Expression _makeWrite(Expression value, bool voidContext) {
     return writeTarget == null
         ? makeInvalidWrite(value)
         : new StaticSet(writeTarget, value)
-      ..fileOffset = offset;
+      ..fileOffset = offsetForToken(token);
   }
 }
 
 class ReadOnlyAccessor extends Accessor {
   Expression expression;
   VariableDeclaration value;
 
-  ReadOnlyAccessor(this.expression, int offset) : super(offset);
+  ReadOnlyAccessor(this.expression, Token token) : super(token);
 
   Expression _makeSimpleRead() => expression;
 
   Expression _makeRead() {
     value ??= new VariableDeclaration.forValue(expression);
     return new VariableGet(value);
   }
 
   Expression _makeWrite(Expression value, bool voidContext) =>
       makeInvalidWrite(value);
@@ skipping 23 matching lines @@
 
 VariableDeclaration makeOrReuseVariable(Expression value) {
   // TODO: Devise a way to remember if a variable declaration was reused
   // or is fresh (hence needs a let binding).
   return new VariableDeclaration.forValue(value);
 }
 
 Expression wrapInvalid(Expression e) {
   return new Let(new VariableDeclaration.forValue(e), new InvalidExpression());
 }