Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3841)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 284183013: Fix some webview plugin attach-ment code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: return value fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index f00fb9b2e6a3440181199217b7d9d4a3e8bba2c3..77bc1a433ce395b36a6da4cb29b393cdc6999db8 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -706,9 +706,7 @@ WebViewInternal.prototype.handleDialogEvent =
};
var self = this;
- var browserPluginNode = this.browserPluginNode;
var webviewNode = this.webviewNode;
-
var requestId = event.requestId;
var actionTaken = false;
@@ -823,7 +821,6 @@ WebViewInternal.prototype.handleNewWindowEvent =
};
var self = this;
- var browserPluginNode = this.browserPluginNode;
var webviewNode = this.webviewNode;
var requestId = event.requestId;
@@ -929,9 +926,7 @@ WebViewInternal.prototype.handlePermissionEvent =
return;
}
- var browserPluginNode = this.browserPluginNode;
var webviewNode = this.webviewNode;
-
var decisionMade = false;
var validateCall = function() {
@@ -1078,9 +1073,7 @@ WebViewInternal.prototype.attachWindowAndSetUpEvents = function(instanceId) {
this.setupEvent(eventName, events[eventName]);
}
- this.browserPluginNode['-internal-attach'](this.instanceId, params);
-
- return true;
+ return this.browserPluginNode['-internal-attach'](this.instanceId, params);
};
// Registers browser plugin <object> custom element.
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698