Issue 284183013: Fix some webview plugin attach-ment code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284183013: Fix some webview plugin attach-ment code. (Closed)

Created:
6 years, 7 months ago by lazyboy

Modified:
6 years, 7 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix some webview plugin attach-ment code. We would show error message on attach failure now, we used to always return true from attachWindowAndSetUpEvents(). attachWindowAndSetUpEvents() now return the value of -internal-attach call. -internal-attach did not used to return value, now it returns the status of the attachment call from BrowserPluginBindings. Removed 3 unused variables referring to browserPluginNode. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272634

Patch Set 1 #

Patch Set 2 : return value fix #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	chrome/renderer/resources/extensions/web_view.js	View		4 chunks	+1 line, -8 lines	0 comments	Download
	M	content/renderer/browser_plugin/browser_plugin_bindings.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/284183013/20001

6 years, 7 months ago (2014-05-23 20:26:26 UTC) #4

Message was sent while issue was closed.

Change committed as 272634

Expand Messages | Collapse Messages