Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 284183012: Bluetooth: remove Profile API (Closed)

Created:
6 years, 7 months ago by keybuk
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Tim Song
Visibility:
Public.

Description

Bluetooth: remove Profile API This CL removes the bluetooth.addProfile and bluetooth.removeProfile API calls, along with the associated bluetooth.onConnection event. Apps should now use bluetoothSocket.connect() and the family of bluetoothSocket.listenUsing*() functions instead. Since those are only implemented on Chrome OS right now this temporarily breaks Windows and OS X, but should make the effort of porting those to the new API easier by removing much of the old code. It also cleans up the bluetooth API by removing the deprecated and non-functional socket methods now that bluetoothSocket is complete. BUG=349475 TEST=unit_tests and browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1635 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 7 chunks +0 lines, -155 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 6 chunks +0 lines, -366 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_socket.h View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_socket.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/extensions/api/bluetooth/bluetooth_api_unittest.cc View 1 chunk +0 lines, -207 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 6 chunks +0 lines, -125 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 6 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 6 chunks +0 lines, -62 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 5 chunks +0 lines, -38 lines 0 comments Download
A + chrome/browser/extensions/api/bluetooth_socket/bluetooth_api_socket.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/bluetooth_socket/bluetooth_api_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/bluetooth.idl View 5 chunks +21 lines, -220 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/on_connection/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/on_connection/runtest.js View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/profiles/manifest.json View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/profiles/runtest.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
keybuk
kalman, miket: for bluetooth.idl OWNERS others: general LGTM
6 years, 7 months ago (2014-05-22 22:45:29 UTC) #1
miket_OOO
.idl LGTM
6 years, 7 months ago (2014-05-22 22:49:15 UTC) #2
not at google - send to devlin
wow... that's a lot of deletion. well, rubberstamp lgtm when the time comes, I trust ...
6 years, 7 months ago (2014-05-22 22:49:57 UTC) #3
Ilya Sherman
Didn't look at the details, but generally LGTM.
6 years, 7 months ago (2014-05-23 15:21:33 UTC) #4
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-05-30 18:15:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/284183012/1
6 years, 6 months ago (2014-05-30 18:18:12 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 03:56:05 UTC) #7
Message was sent while issue was closed.
Change committed as 274000

Powered by Google App Engine
This is Rietveld 408576698