components/favicon.gypi - Issue 284183004: Create favicon_url mirror in components/favicon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon.gypi

Issue 284183004: Create favicon_url mirror in components/favicon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes 2. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon.gypi

diff --git a/components/favicon.gypi b/components/favicon.gypi

index 0d44dd3ff3a624998de6bfeaa874fe687fbe48ee..be36213c56263b3673d2f65c0e1c9b5280bbe1d3 100644

--- a/components/favicon.gypi

+++ b/components/favicon.gypi

@@ -6,10 +6,19 @@

'targets': [

{

'target_name': 'favicon_core',

- 'type': 'none',

+ 'type': 'static_library',

+ 'dependencies': [

+ '../ui/gfx/gfx.gyp:gfx_geometry',

+ 'favicon_base',

+ ],

'sources': [

'favicon/core/browser/favicon_client.h',

'favicon/core/favicon_driver.h',

+ 'favicon/core/favicon_url.cc',

+ 'favicon/core/favicon_url.h',

+ ],

+ 'include_dirs': [

+ '..',

« no previous file with comments | « no previous file | components/favicon/DEPS » ('j') | no next file with comments »