Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon.gypi

Issue 284183004: Create favicon_url mirror in components/favicon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/favicon/DEPS » ('j') | components/favicon/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon.gypi
diff --git a/components/favicon.gypi b/components/favicon.gypi
index 0d44dd3ff3a624998de6bfeaa874fe687fbe48ee..a0e378a0d0d3321839ecb2c013ae7851dad4c84c 100644
--- a/components/favicon.gypi
+++ b/components/favicon.gypi
@@ -6,10 +6,15 @@
'targets': [
{
'target_name': 'favicon_core',
- 'type': 'none',
+ 'type': 'static_library',
'sources': [
'favicon/core/browser/favicon_client.h',
'favicon/core/favicon_driver.h',
+ 'favicon/core/favicon_url.cc',
+ 'favicon/core/favicon_url.h',
+ ],
+ 'include_dirs': [
+ '..',
],
},
],
« no previous file with comments | « no previous file | components/favicon/DEPS » ('j') | components/favicon/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698