Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 284183003: Add MediaDrmBridge::AddKeySystemUuidMapping(). (Closed)

Created:
6 years, 7 months ago by ycheo (away)
Modified:
6 years, 7 months ago
Reviewers:
qinmin, xhwang, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Visibility:
Public.

Description

Add MediaDrmBridge::AddKeySystemUuidMapping(). This method is needed to inject the other DRMs' keysystem and uuid mapping in MediaDrmBridge. BUG=322395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272498

Patch Set 1 : #

Total comments: 26

Patch Set 2 : addressed reviewers' comments. #

Total comments: 10

Patch Set 3 : addressed xhwang's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -11 lines) Patch
M media/base/android/media_drm_bridge.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 2 6 chunks +51 lines, -11 lines 0 comments Download
M media/base/android/media_drm_bridge_unittest.cc View 1 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ycheo (away)
PTAL.
6 years, 7 months ago (2014-05-15 12:46:24 UTC) #1
xhwang
https://codereview.chromium.org/284183003/diff/20001/media/base/android/media_drm_bridge.cc File media/base/android/media_drm_bridge.cc (right): https://codereview.chromium.org/284183003/diff/20001/media/base/android/media_drm_bridge.cc#newcode30 media/base/android/media_drm_bridge.cc:30: namespace { In media code, we use "static" a ...
6 years, 7 months ago (2014-05-15 15:10:29 UTC) #2
ddorwin
https://codereview.chromium.org/284183003/diff/20001/media/base/android/media_drm_bridge.cc File media/base/android/media_drm_bridge.cc (right): https://codereview.chromium.org/284183003/diff/20001/media/base/android/media_drm_bridge.cc#newcode73 media/base/android/media_drm_bridge.cc:73: typedef std::vector<KeySystemUuidPair> KeySystemUuidTable; On 2014/05/15 15:10:29, xhwang wrote: > ...
6 years, 7 months ago (2014-05-15 19:00:45 UTC) #3
ycheo (away)
PTAL. I changed vector<> to hash_map<>. And also I wrapped the related functions with a ...
6 years, 7 months ago (2014-05-16 04:53:37 UTC) #4
ycheo (away)
PTAL.
6 years, 7 months ago (2014-05-19 22:28:46 UTC) #5
xhwang
lgtm % nits https://codereview.chromium.org/284183003/diff/90001/media/base/android/media_drm_bridge.cc File media/base/android/media_drm_bridge.cc (right): https://codereview.chromium.org/284183003/diff/90001/media/base/android/media_drm_bridge.cc#newcode69 media/base/android/media_drm_bridge.cc:69: typedef std::vector<uint8> UUID; nit: Add an ...
6 years, 7 months ago (2014-05-21 17:11:08 UTC) #6
ycheo (away)
Thanks for the review. https://codereview.chromium.org/284183003/diff/90001/media/base/android/media_drm_bridge.cc File media/base/android/media_drm_bridge.cc (right): https://codereview.chromium.org/284183003/diff/90001/media/base/android/media_drm_bridge.cc#newcode69 media/base/android/media_drm_bridge.cc:69: typedef std::vector<uint8> UUID; On 2014/05/21 ...
6 years, 7 months ago (2014-05-21 23:35:11 UTC) #7
ycheo (away)
The CQ bit was checked by ycheo@chromium.org
6 years, 7 months ago (2014-05-23 08:56:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/284183003/110001
6 years, 7 months ago (2014-05-23 08:57:36 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:48:42 UTC) #10
Message was sent while issue was closed.
Change committed as 272498

Powered by Google App Engine
This is Rietveld 408576698