Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: content/browser/PRESUBMIT.py

Issue 2841823007: Fix presubmit_scheme_histograms.py and presubmit_bad_message_reasons.py (Closed)
Patch Set: Fixed typos / nits in comments and error strings. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/PRESUBMIT.py
diff --git a/content/browser/PRESUBMIT.py b/content/browser/PRESUBMIT.py
index 67e1c2a7c0f2b67b768a4adc05de600542c5fa1e..a4beb857df29c27295ef7259c751078d6a1d7d34 100644
--- a/content/browser/PRESUBMIT.py
+++ b/content/browser/PRESUBMIT.py
@@ -6,6 +6,12 @@
match the corresponding bad_message.h file.
"""
+def CheckChangeOnCommit(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
+
def _RunHistogramChecks(input_api, output_api, histogram_name):
try:
# Setup sys.path so that we can call histrogram code
ncarter (slow) 2017/04/27 23:35:52 "histrogram" is a typo
Łukasz Anforowicz 2017/04/27 23:59:04 Done (in 5 cases where this typo got copy&pasted :
@@ -24,5 +30,5 @@ def _RunHistogramChecks(input_api, output_api, histogram_name):
finally:
sys.path = original_sys_path
-def CheckChangeOnUpload(input_api, output_api):
+def _CommonChecks(input_api, output_api):
return _RunHistogramChecks(input_api, output_api, "BadMessageReasonContent")
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698