Fix presubmit_scheme_histograms.py and presubmit_bad_message_reasons.py

content/browser/PRESUBMIT.py

Index: content/browser/PRESUBMIT.py
diff --git a/content/browser/PRESUBMIT.py b/content/browser/PRESUBMIT.py
index 67e1c2a7c0f2b67b768a4adc05de600542c5fa1e..a4beb857df29c27295ef7259c751078d6a1d7d34 100644
--- a/content/browser/PRESUBMIT.py
+++ b/content/browser/PRESUBMIT.py
@@ -6,6 +6,12 @@
 match the corresponding bad_message.h file.
 """
 
+def CheckChangeOnCommit(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+
+def CheckChangeOnUpload(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+

[Łukasz Anforowicz, 2017/04/26 22:20:54]

I don't understand why we have separate CheckChangeOnCommit and a separate
CheckChangeOnUpload.  Sometimes commit happens a little while after an upload
and it seems useful to have the same checks apply in both cases (in case
something landed recently that would have messed up the histogram enums).

I see that other presubmit scripts (i.e. the one in
//chrome/browser/PRESUBMIT.py) use the _CommonChecks pattern to work around
this.

 def _RunHistogramChecks(input_api, output_api, histogram_name):
   try:
     # Setup sys.path so that we can call histrogram code
@@ -24,5 +30,5 @@ def _RunHistogramChecks(input_api, output_api, histogram_name):
   finally:
     sys.path = original_sys_path
 
-def CheckChangeOnUpload(input_api, output_api):
+def _CommonChecks(input_api, output_api):
   return _RunHistogramChecks(input_api, output_api, "BadMessageReasonContent")