Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/PRESUBMIT.py

Issue 2841823007: Fix presubmit_scheme_histograms.py and presubmit_bad_message_reasons.py (Closed)
Patch Set: Fix an old typo in _RunHistogramChecks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/content/browser/PRESUBMIT.py ('k') | extensions/browser/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/PRESUBMIT.py
diff --git a/content/browser/PRESUBMIT.py b/content/browser/PRESUBMIT.py
index 67e1c2a7c0f2b67b768a4adc05de600542c5fa1e..192cc15b36c23b2e8117024dfecc406ef59eedc2 100644
--- a/content/browser/PRESUBMIT.py
+++ b/content/browser/PRESUBMIT.py
@@ -6,9 +6,15 @@
match the corresponding bad_message.h file.
"""
+def CheckChangeOnCommit(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
+
def _RunHistogramChecks(input_api, output_api, histogram_name):
try:
- # Setup sys.path so that we can call histrogram code
+ # Setup sys.path so that we can call histograms code.
import sys
original_sys_path = sys.path
sys.path = sys.path + [input_api.os_path.join(
@@ -24,5 +30,5 @@ def _RunHistogramChecks(input_api, output_api, histogram_name):
finally:
sys.path = original_sys_path
-def CheckChangeOnUpload(input_api, output_api):
+def _CommonChecks(input_api, output_api):
return _RunHistogramChecks(input_api, output_api, "BadMessageReasonContent")
« no previous file with comments | « components/password_manager/content/browser/PRESUBMIT.py ('k') | extensions/browser/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698