OLD | NEW |
1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Chromium presubmit script for src/extensions/browser. | 5 """Chromium presubmit script for src/extensions/browser. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details on the presubmit API built into depot_tools. | 8 for more details on the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
(...skipping 18 matching lines...) Expand all Loading... |
29 def _RunHistogramValueCheckers(input_api, output_api): | 29 def _RunHistogramValueCheckers(input_api, output_api): |
30 results = [] | 30 results = [] |
31 histogram_paths = ('extensions/browser/extension_event_histogram_value.h', | 31 histogram_paths = ('extensions/browser/extension_event_histogram_value.h', |
32 'extensions/browser/extension_function_histogram_value.h') | 32 'extensions/browser/extension_function_histogram_value.h') |
33 for path in histogram_paths: | 33 for path in histogram_paths: |
34 results += _CreateHistogramValueChecker(input_api, output_api, path).Run() | 34 results += _CreateHistogramValueChecker(input_api, output_api, path).Run() |
35 return results | 35 return results |
36 | 36 |
37 def _RunHistogramChecks(input_api, output_api, histogram_name): | 37 def _RunHistogramChecks(input_api, output_api, histogram_name): |
38 try: | 38 try: |
39 # Setup sys.path so that we can call histrogram code | 39 # Setup sys.path so that we can call histograms code. |
40 import sys | 40 import sys |
41 original_sys_path = sys.path | 41 original_sys_path = sys.path |
42 sys.path = sys.path + [input_api.os_path.join( | 42 sys.path = sys.path + [input_api.os_path.join( |
43 input_api.change.RepositoryRoot(), | 43 input_api.change.RepositoryRoot(), |
44 'tools', 'metrics', 'histograms')] | 44 'tools', 'metrics', 'histograms')] |
45 | 45 |
46 import presubmit_bad_message_reasons | 46 import presubmit_bad_message_reasons |
47 return presubmit_bad_message_reasons.PrecheckBadMessage(input_api, | 47 return presubmit_bad_message_reasons.PrecheckBadMessage(input_api, |
48 output_api, histogram_name) | 48 output_api, histogram_name) |
49 except: | 49 except: |
50 return [output_api.PresubmitError('Could not verify histogram!')] | 50 return [output_api.PresubmitError('Could not verify histogram!')] |
51 finally: | 51 finally: |
52 sys.path = original_sys_path | 52 sys.path = original_sys_path |
53 | 53 |
54 def CheckChangeOnUpload(input_api, output_api): | 54 def CheckChangeOnUpload(input_api, output_api): |
55 results = [] | 55 results = [] |
56 results += _RunHistogramValueCheckers(input_api, output_api) | 56 results += _RunHistogramValueCheckers(input_api, output_api) |
57 results += _RunHistogramChecks(input_api, output_api, | 57 results += _RunHistogramChecks(input_api, output_api, |
58 "BadMessageReasonExtensions") | 58 "BadMessageReasonExtensions") |
59 return results | 59 return results |
OLD | NEW |