third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2841823006: Resolve inline margins in over-constrained situations correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2841823006: Resolve inline margins in over-constrained situations correctly. (Closed)

Patch Set: In regular block layout, the width of a child's margin box should always be equal to that of its containing block Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 6f2ceee06cd38b7eebf8828ca9cde565f9b1a570..0b395f635b1289b1d0c0d1ec96d7993411d01306 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2702,8 +2702,15 @@ void LayoutBox::ComputeLogicalWidth(

computed_values.margins_.start_, computed_values.margins_.end_,

Style()->MarginStart(), Style()->MarginEnd());

+ // CSS 2.1 10.3.3

+ // If 'width' is not 'auto' and 'border-left-width' + 'padding-left' + 'width'

+ // + 'padding-right' + 'border-right-width' (plus any of 'margin-left' or

+ // 'margin-right' that are not 'auto') is larger than the width of the

+ // containing block, then any 'auto' values for 'margin-left' or

+ // 'margin-right' treated as zero. The following should only apply for parent

+ // width >= children width

mstensho (USE GERRIT) 2017/04/27 12:37:28 You could remove that last sentence (or at least w

if (!has_perpendicular_containing_block && container_logical_width &&

- container_logical_width !=

+ container_logical_width >

(computed_values.extent_ + computed_values.margins_.start_ +

computed_values.margins_.end_) &&

!IsFloating() && !IsInline() && !cb->IsFlexibleBoxIncludingDeprecated() &&

« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp » ('J')