Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: ui/gfx/color_transform_unittest.cc

Issue 2841813002: Converting video color space enums to their corresponding gfx:color space eqvivalent. (Closed)
Patch Set: Removed gfx::ColorSpace::CreateVideo() Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/ffmpeg_video_decoder.cc ('K') | « ui/gfx/color_space.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/color_transform_unittest.cc
diff --git a/ui/gfx/color_transform_unittest.cc b/ui/gfx/color_transform_unittest.cc
index 289e0012a6cc110d1209bb787e778b842a876caa..b6d9c08ab655c080edcb2d5f7035959b7d3ece22 100644
--- a/ui/gfx/color_transform_unittest.cc
+++ b/ui/gfx/color_transform_unittest.cc
@@ -313,8 +313,9 @@ TEST(SimpleColorSpace, GetColorSpace) {
TEST(SimpleColorSpace, UnknownVideoToSRGB) {
// Invalid video spaces should be BT709.
- ColorSpace unknown = gfx::ColorSpace::CreateVideo(
- -1, -1, -1, gfx::ColorSpace::RangeID::LIMITED);
+ ColorSpace unknown = gfx::ColorSpace(
+ gfx::ColorSpace::PrimaryID::INVALID, gfx::ColorSpace::TransferID::INVALID,
+ gfx::ColorSpace::MatrixID::INVALID, gfx::ColorSpace::RangeID::LIMITED);
ccameron 2017/05/03 14:56:24 I think that this test will fail because INVALID w
ColorSpace sRGB = ColorSpace::CreateSRGB();
std::unique_ptr<ColorTransform> t(ColorTransform::NewColorTransform(
unknown, sRGB, ColorTransform::Intent::INTENT_PERCEPTUAL));
« media/filters/ffmpeg_video_decoder.cc ('K') | « ui/gfx/color_space.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698