src/objects.cc - Issue 2841633004: [regexp] Fix passing all flags to RegExp construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2841633004: [regexp] Fix passing all flags to RegExp construction (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 5636d826064c44024bbdef0bc7eaeb81177c6457..542ec28bb695a209682437b4764101d3b898cf7e 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -16225,7 +16225,7 @@ JSRegExp::Flags RegExpFlagsFromString(Handle<String> flags, bool* success) {

JSRegExp::Flags value = JSRegExp::kNone;

int length = flags->length();

// A longer flags string cannot be valid.

- if (length > 5) return JSRegExp::Flags(0);

+ if (length > JSRegExp::FlagCount()) return JSRegExp::Flags(0);

for (int i = 0; i < length; i++) {

JSRegExp::Flag flag = JSRegExp::kNone;

switch (flags->Get(i)) {

« no previous file with comments | « src/objects.h ('k') | test/mjsunit/harmony/regexp-dotall.js » ('j') | no next file with comments »