Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 284163002: Better arity checks for overloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 284163002: Better arity checks for overloads (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Return properly Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

index f1eb059c4f41f3ddf9325b579822e17feb1365df..59322aefa0b2f13d40ead64458694f37bb48b6aa 100644

--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -75,7 +75,7 @@ static void attr1AttributeSetterCallback(v8::Local<v8::String>, v8::Local<v8::Va

static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

if (UNLIKELY(info.Length() < 1)) {

- throwArityTypeErrorForMethod("func", "TestInterfaceWillBeGarbageCollected", 1, info.Length(), info.GetIsolate());

+ throwMinimumArityTypeErrorForMethod("func", "TestInterfaceWillBeGarbageCollected", 1, info.Length(), info.GetIsolate());

return;

}

TestInterfaceWillBeGarbageCollected* impl = V8TestInterfaceWillBeGarbageCollected::toNative(info.Holder());

@@ -94,7 +94,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

{

v8::Isolate* isolate = info.GetIsolate();

if (UNLIKELY(info.Length() < 1)) {

- throwArityTypeErrorForConstructor("TestInterfaceWillBeGarbageCollected", 1, info.Length(), info.GetIsolate());

+ throwMinimumArityTypeErrorForConstructor("TestInterfaceWillBeGarbageCollected", 1, info.Length(), info.GetIsolate());

return;

}

TOSTRING_VOID(V8StringResource<>, str, info[0]);