Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp - Issue 284163002: Better arity checks for overloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

Issue 284163002: Better arity checks for overloads (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Return properly Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

index 9567b39369720ef3162213e12e06a006cf5ca56e..e4a7a5126e5cd0b8cc603af1a981f5c448738f06 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

@@ -94,7 +94,7 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio

ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceNamedConstructor", info.Holder(), isolate);

if (UNLIKELY(info.Length() < 1)) {

- throwArityTypeError(exceptionState, 1, info.Length());

+ throwMinimumArityTypeError(exceptionState, 1, info.Length());

return;

}

TOSTRING_VOID(V8StringResource<>, stringArg, info[0]);