Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp - Issue 284163002: Better arity checks for overloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

Issue 284163002: Better arity checks for overloads (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Return properly Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

index 8d5760d199b4fac8f0ed79b4687c6b6b412bed61..c72603d4b9cd3dfcb25389abaab70883fb4c8cac 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

@@ -145,8 +145,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

return;

}

break;

- }

- if (UNLIKELY(info.Length() < 1)) {

+ default:

exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, info.Length()));

exceptionState.throwIfNeeded();

return;