media/renderers/video_overlay_factory.cc - Issue 2841553003: media: Discard the previous decoder immediately on fallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/video_overlay_factory.cc

Issue 2841553003: media: Discard the previous decoder immediately on fallback (Closed)

Patch Set: Remove out of date comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/renderers/video_overlay_factory.cc

diff --git a/media/renderers/video_overlay_factory.cc b/media/renderers/video_overlay_factory.cc

index 6bb1f0f8f614dc41f8e9b4f0053c8f2effd38dc7..a5a935b56ab03dea9b3ed1cb83af01b4cecc4e89 100644

--- a/media/renderers/video_overlay_factory.cc

+++ b/media/renderers/video_overlay_factory.cc

@@ -107,9 +107,6 @@ scoped_refptr<VideoFrame> VideoOverlayFactory::CreateFrame(

base::TimeDelta()); // timestamp

CHECK(frame);

frame->metadata()->SetBoolean(VideoFrameMetadata::ALLOW_OVERLAY, true);

- // TODO(halliwell): this is to block idle suspend behaviour on Chromecast.

- // Find a better way to do this.

- frame->metadata()->SetBoolean(VideoFrameMetadata::DECODER_OWNS_FRAME, true);

return frame;

}