Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2841553003: media: Discard the previous decoder immediately on fallback (Closed)
Patch Set: Remove out of date comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index f2ba41b4781f8ebe650e0c5cedd43ea28924c943..221e588e05009d49f5dad60d7b7902e67ad28db3 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -880,9 +880,7 @@ void WebMediaPlayerImpl::Paint(blink::WebCanvas* canvas,
DCHECK(main_task_runner_->BelongsToCurrentThread());
TRACE_EVENT0("media", "WebMediaPlayerImpl:paint");
- // TODO(sandersd): Move this check into GetCurrentFrameFromCompositor() when
- // we have other ways to check if decoder owns video frame.
- // See http://crbug.com/595716 and http://crbug.com/602708
+ // We can't copy from protected frames.
if (cdm_)
return;
@@ -958,9 +956,7 @@ bool WebMediaPlayerImpl::CopyVideoTextureToPlatformTexture(
DCHECK(main_task_runner_->BelongsToCurrentThread());
TRACE_EVENT0("media", "WebMediaPlayerImpl:copyVideoTextureToPlatformTexture");
- // TODO(sandersd): Move this check into GetCurrentFrameFromCompositor() when
- // we have other ways to check if decoder owns video frame.
- // See http://crbug.com/595716 and http://crbug.com/602708
+ // We can't copy from protected frames.
if (cdm_)
return false;

Powered by Google App Engine
This is Rietveld 408576698