chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h - Issue 2841553002: Allow machine key challenges by signin profiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h

Issue 2841553002: Allow machine key challenges by signin profiles. (Closed)

Patch Set: Review nits. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h

diff --git a/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h

index 99e0b9985ce7b09f64acfe1f90158f4a1ab10e84..1092ba4506d87a70f43393ef79817399e9f37726 100644

--- a/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h

+++ b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h

@@ -20,6 +20,7 @@

#include "chromeos/dbus/dbus_method_call_status.h"

#include "components/signin/core/account_id/account_id.h"

#include "extensions/browser/extension_function.h"

+#include "extensions/common/extension.h"

#include "third_party/cros_system_api/dbus/service_constants.h"

class Profile;

@@ -117,7 +118,7 @@ class EPKPChallengeKeyBase {

default_attestation_flow_;

ChallengeKeyCallback callback_;

Profile* profile_;

- std::string extension_id_;

+ scoped_refptr<const Extension> extension_;

private:

// Holds the context of a PrepareKey() operation.