src/ic-inl.h - Issue 284153004: Avoid flushing the icache unnecessarily when updating target addresses in code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic-inl.h

Issue 284153004: Avoid flushing the icache unnecessarily when updating target addresses in code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Update SKIP_ICACHE_FLUSH_IF_ATOMIC to only skip when patching a single instruction. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic-inl.h

diff --git a/src/ic-inl.h b/src/ic-inl.h

index 010df08c664aae08657e13e8838e3826270e6e82..30484d623333021003960f95406de357d9959a59 100644

--- a/src/ic-inl.h

+++ b/src/ic-inl.h

@@ -94,7 +94,8 @@ Code* IC::GetTargetAtAddress(Address address,

void IC::SetTargetAtAddress(Address address,

Code* target,

- ConstantPoolArray* constant_pool) {

+ ConstantPoolArray* constant_pool,

+ ICacheFlushMode icache_flush_mode) {

ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub());

Heap* heap = target->GetHeap();

Code* old_target = GetTargetAtAddress(address, constant_pool);

@@ -108,7 +109,7 @@ void IC::SetTargetAtAddress(Address address,

}

#endif

Assembler::set_target_address_at(

- address, constant_pool, target->instruction_start());

+ address, constant_pool, target->instruction_start(), icache_flush_mode);

if (heap->gc_state() == Heap::MARK_COMPACT) {

heap->mark_compact_collector()->RecordCodeTargetPatch(address, target);

} else {

« src/arm/assembler-arm-inl.h ('K') | « src/ic.cc ('k') | src/objects.cc » ('j') | no next file with comments »