Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: src/arm/assembler-arm.h

Issue 284153004: Avoid flushing the icache unnecessarily when updating target addresses in code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix intenting Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/assembler-arm-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 745 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 // Return the address in the constant pool of the code target address used by 756 // Return the address in the constant pool of the code target address used by
757 // the branch/call instruction at pc, or the object in a mov. 757 // the branch/call instruction at pc, or the object in a mov.
758 INLINE(static Address target_constant_pool_address_at( 758 INLINE(static Address target_constant_pool_address_at(
759 Address pc, ConstantPoolArray* constant_pool)); 759 Address pc, ConstantPoolArray* constant_pool));
760 760
761 // Read/Modify the code target address in the branch/call instruction at pc. 761 // Read/Modify the code target address in the branch/call instruction at pc.
762 INLINE(static Address target_address_at(Address pc, 762 INLINE(static Address target_address_at(Address pc,
763 ConstantPoolArray* constant_pool)); 763 ConstantPoolArray* constant_pool));
764 INLINE(static void set_target_address_at(Address pc, 764 INLINE(static void set_target_address_at(Address pc,
765 ConstantPoolArray* constant_pool, 765 ConstantPoolArray* constant_pool,
766 Address target)); 766 Address target,
767 ICacheFlushMode icache_flush_mode =
768 FLUSH_ICACHE_IF_NEEDED));
767 INLINE(static Address target_address_at(Address pc, Code* code)) { 769 INLINE(static Address target_address_at(Address pc, Code* code)) {
768 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL; 770 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
769 return target_address_at(pc, constant_pool); 771 return target_address_at(pc, constant_pool);
770 } 772 }
771 INLINE(static void set_target_address_at(Address pc, 773 INLINE(static void set_target_address_at(Address pc,
772 Code* code, 774 Code* code,
773 Address target)) { 775 Address target,
776 ICacheFlushMode icache_flush_mode =
777 FLUSH_ICACHE_IF_NEEDED)) {
774 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL; 778 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
775 set_target_address_at(pc, constant_pool, target); 779 set_target_address_at(pc, constant_pool, target, icache_flush_mode);
776 } 780 }
777 781
778 // Return the code target address at a call site from the return address 782 // Return the code target address at a call site from the return address
779 // of that call in the instruction stream. 783 // of that call in the instruction stream.
780 INLINE(static Address target_address_from_return_address(Address pc)); 784 INLINE(static Address target_address_from_return_address(Address pc));
781 785
782 // Given the address of the beginning of a call, return the address 786 // Given the address of the beginning of a call, return the address
783 // in the instruction stream that the call will return from. 787 // in the instruction stream that the call will return from.
784 INLINE(static Address return_address_from_call_start(Address pc)); 788 INLINE(static Address return_address_from_call_start(Address pc));
785 789
(...skipping 839 matching lines...) Expand 10 before | Expand all | Expand 10 after
1625 public: 1629 public:
1626 explicit EnsureSpace(Assembler* assembler) { 1630 explicit EnsureSpace(Assembler* assembler) {
1627 assembler->CheckBuffer(); 1631 assembler->CheckBuffer();
1628 } 1632 }
1629 }; 1633 };
1630 1634
1631 1635
1632 } } // namespace v8::internal 1636 } } // namespace v8::internal
1633 1637
1634 #endif // V8_ARM_ASSEMBLER_ARM_H_ 1638 #endif // V8_ARM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/assembler-arm-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698