third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-menu-element/menuitem-label.html - Issue 2841473002: Implement HTMLMenuItemElement.label

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-menu-element/menuitem-label.html

Issue 2841473002: Implement HTMLMenuItemElement.label (Closed)

Patch Set: Reflect review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../../../../../../resources/testharness.js'></script>
	tkent 2017/04/26 08:59:58 Please use absolute link in external/wpt/. <scrip Please use absolute link in external/wpt/. <script src='/resources/testharness.js'></script> yuzuchan 2017/04/26 10:28:30 Done. Show quoted text On 2017/04/26 at 08:59:58, tkent wrote: > Please use absolute link in external/wpt/. > > <script src='/resources/testharness.js'></script> Done. tkent 2017/04/26 22:32:30 BTW, here is the document about external/wpt/: htt BTW, here is the document about external/wpt/: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat... I'll explain more offline.
	3 <script src='../../../../../../resources/testharnessreport.js'></script>
	tkent 2017/04/26 08:59:58 Ditto. Ditto. yuzuchan 2017/04/26 10:28:30 Done. Show quoted text On 2017/04/26 at 08:59:58, tkent wrote: > Ditto. Done. yuzuchan 2017/04/26 10:28:30 Done. Show quoted text On 2017/04/26 at 08:59:58, tkent wrote: > Ditto. Done.
	4 <menuitem id='item1' label='item1'></menuitem>

	5 <menuitem id='item2'>item2</menuitem>

	6 <menuitem id='item3'> item 3 </menuitem>

	7 <menuitem id='item4' label=''>item4</menuitem>

	8 <menuitem id='item5' label=' item 5 '></menuitem>

	9

	10 <script>

	11 test(() => {

	12 assert_equals(document.querySelector('#item1').label, 'item1');

	13 assert_equals(document.querySelector('#item2').label, 'item2');

	14 assert_equals(document.querySelector('#item3').label, 'item 3');

	15 assert_equals(document.querySelector('#item4').label, '');

	16 assert_equals(document.querySelector('#item5').label, ' item 5 ');

	17 }, 'Menuitem.label should be the label attribute content or the result of '

	18 + 'stripping and collapsing ASCII whitespace from the child text content.');

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMenuItemElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLMenuItemElement.h » ('J')